fix: tiny-skia quad handle case where border_radius < border_width / 2.0
This commit is contained in:
parent
5ee26cc8ec
commit
102c78abd8
1 changed files with 83 additions and 7 deletions
|
|
@ -1,3 +1,5 @@
|
||||||
|
use tiny_skia::{Mask, Pixmap, PixmapPaint};
|
||||||
|
|
||||||
use crate::core::text;
|
use crate::core::text;
|
||||||
use crate::core::{Background, Color, Font, Point, Rectangle, Size, Vector};
|
use crate::core::{Background, Color, Font, Point, Rectangle, Size, Vector};
|
||||||
use crate::graphics::backend;
|
use crate::graphics::backend;
|
||||||
|
|
@ -212,17 +214,29 @@ impl Backend {
|
||||||
height: bounds.height - border_width,
|
height: bounds.height - border_width,
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// Make sure the border radius is correct
|
||||||
let mut border_radius = *border_radius;
|
let mut border_radius = *border_radius;
|
||||||
for radius in &mut border_radius {
|
let mut border_radius_gt_half_border_width =
|
||||||
*radius = radius
|
[true, true, true, true];
|
||||||
.min(path_bounds.width / 2.0)
|
for (i, radius) in &mut border_radius.iter_mut().enumerate() {
|
||||||
.min(path_bounds.height / 2.0);
|
*radius = if *radius == 0.0 {
|
||||||
|
// Path should handle this fine
|
||||||
|
0.0
|
||||||
|
} else if *radius > border_width / 2.0 {
|
||||||
|
*radius - border_width / 2.0
|
||||||
|
} else {
|
||||||
|
border_radius_gt_half_border_width[i] = false;
|
||||||
|
0.0
|
||||||
|
}
|
||||||
|
.min(path_bounds.width / 2.0)
|
||||||
|
.min(path_bounds.height / 2.0);
|
||||||
}
|
}
|
||||||
|
|
||||||
let border_radius_path =
|
// Stroking a path works well in this case.
|
||||||
rounded_rectangle(path_bounds, border_radius);
|
if border_radius_gt_half_border_width.iter().all(|b| *b) {
|
||||||
|
let border_radius_path =
|
||||||
|
rounded_rectangle(path_bounds, border_radius);
|
||||||
|
|
||||||
if border_width > 0.0 {
|
|
||||||
pixels.stroke_path(
|
pixels.stroke_path(
|
||||||
&border_radius_path,
|
&border_radius_path,
|
||||||
&tiny_skia::Paint {
|
&tiny_skia::Paint {
|
||||||
|
|
@ -239,6 +253,68 @@ impl Backend {
|
||||||
transform,
|
transform,
|
||||||
clip_mask,
|
clip_mask,
|
||||||
);
|
);
|
||||||
|
} else {
|
||||||
|
// Draw corners that have to small border radii as having no border radius,
|
||||||
|
// but mask them with the rounded rectangle with the correct border radius.
|
||||||
|
|
||||||
|
let mut temp_pixmap =
|
||||||
|
Pixmap::new(bounds.width as u32, bounds.height as u32)
|
||||||
|
.unwrap();
|
||||||
|
|
||||||
|
let mut quad_mask =
|
||||||
|
Mask::new(bounds.width as u32, bounds.height as u32)
|
||||||
|
.unwrap();
|
||||||
|
|
||||||
|
let zero_bounds = Rectangle {
|
||||||
|
x: 0.0,
|
||||||
|
y: 0.0,
|
||||||
|
width: bounds.width,
|
||||||
|
height: bounds.height,
|
||||||
|
};
|
||||||
|
let path =
|
||||||
|
rounded_rectangle(zero_bounds, fill_border_radius);
|
||||||
|
|
||||||
|
quad_mask.fill_path(
|
||||||
|
&path,
|
||||||
|
tiny_skia::FillRule::EvenOdd,
|
||||||
|
true,
|
||||||
|
transform,
|
||||||
|
);
|
||||||
|
let path_bounds = Rectangle {
|
||||||
|
x: border_width / 2.0,
|
||||||
|
y: border_width / 2.0,
|
||||||
|
width: bounds.width - border_width,
|
||||||
|
height: bounds.height - border_width,
|
||||||
|
};
|
||||||
|
|
||||||
|
let border_radius_path =
|
||||||
|
rounded_rectangle(path_bounds, border_radius);
|
||||||
|
|
||||||
|
temp_pixmap.stroke_path(
|
||||||
|
&border_radius_path,
|
||||||
|
&tiny_skia::Paint {
|
||||||
|
shader: tiny_skia::Shader::SolidColor(into_color(
|
||||||
|
*border_color,
|
||||||
|
)),
|
||||||
|
anti_alias: true,
|
||||||
|
..tiny_skia::Paint::default()
|
||||||
|
},
|
||||||
|
&tiny_skia::Stroke {
|
||||||
|
width: border_width,
|
||||||
|
..tiny_skia::Stroke::default()
|
||||||
|
},
|
||||||
|
transform,
|
||||||
|
Some(&quad_mask),
|
||||||
|
);
|
||||||
|
|
||||||
|
pixels.draw_pixmap(
|
||||||
|
bounds.x as i32,
|
||||||
|
bounds.y as i32,
|
||||||
|
temp_pixmap.as_ref(),
|
||||||
|
&PixmapPaint::default(),
|
||||||
|
transform,
|
||||||
|
clip_mask,
|
||||||
|
);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
Primitive::Text {
|
Primitive::Text {
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue