Merge pull request #1749 from FinnPerry/fix/add-width-to-scrollable

Configurable `width` for `Scrollable`
This commit is contained in:
Héctor Ramón 2023-04-13 00:03:22 +02:00 committed by GitHub
commit 1de7da1091
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -33,6 +33,7 @@ where
Renderer::Theme: StyleSheet, Renderer::Theme: StyleSheet,
{ {
id: Option<Id>, id: Option<Id>,
width: Length,
height: Length, height: Length,
vertical: Properties, vertical: Properties,
horizontal: Option<Properties>, horizontal: Option<Properties>,
@ -50,6 +51,7 @@ where
pub fn new(content: impl Into<Element<'a, Message, Renderer>>) -> Self { pub fn new(content: impl Into<Element<'a, Message, Renderer>>) -> Self {
Scrollable { Scrollable {
id: None, id: None,
width: Length::Shrink,
height: Length::Shrink, height: Length::Shrink,
vertical: Properties::default(), vertical: Properties::default(),
horizontal: None, horizontal: None,
@ -65,6 +67,12 @@ where
self self
} }
/// Sets the width of the [`Scrollable`].
pub fn width(mut self, width: impl Into<Length>) -> Self {
self.width = width.into();
self
}
/// Sets the height of the [`Scrollable`]. /// Sets the height of the [`Scrollable`].
pub fn height(mut self, height: impl Into<Length>) -> Self { pub fn height(mut self, height: impl Into<Length>) -> Self {
self.height = height.into(); self.height = height.into();
@ -173,7 +181,7 @@ where
} }
fn width(&self) -> Length { fn width(&self) -> Length {
self.content.as_widget().width() self.width
} }
fn height(&self) -> Length { fn height(&self) -> Length {
@ -188,7 +196,7 @@ where
layout( layout(
renderer, renderer,
limits, limits,
Widget::<Message, Renderer>::width(self), self.width,
self.height, self.height,
self.horizontal.is_some(), self.horizontal.is_some(),
|renderer, limits| { |renderer, limits| {
@ -397,15 +405,7 @@ pub fn layout<Renderer>(
horizontal_enabled: bool, horizontal_enabled: bool,
layout_content: impl FnOnce(&Renderer, &layout::Limits) -> layout::Node, layout_content: impl FnOnce(&Renderer, &layout::Limits) -> layout::Node,
) -> layout::Node { ) -> layout::Node {
let limits = limits let limits = limits.width(width).height(height);
.max_height(f32::INFINITY)
.max_width(if horizontal_enabled {
f32::INFINITY
} else {
limits.max().width
})
.width(width)
.height(height);
let child_limits = layout::Limits::new( let child_limits = layout::Limits::new(
Size::new(limits.min().width, 0.0), Size::new(limits.min().width, 0.0),