Merge pull request #2585 from dtzxporter/scrollbar-show-always-disabled

Scrollbar disabled style status to allow custom styles for always visible, but not overflowing scrollbars.
This commit is contained in:
Héctor 2025-01-06 20:37:21 +01:00 committed by GitHub
commit 2b4f428cf8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -906,14 +906,21 @@ where
is_vertical_scrollbar_dragged: state is_vertical_scrollbar_dragged: state
.y_scroller_grabbed_at .y_scroller_grabbed_at
.is_some(), .is_some(),
is_horizontal_scrollbar_disabled: scrollbars.is_x_disabled(),
is_vertical_scrollbar_disabled: scrollbars.is_y_disabled(),
} }
} else if cursor_over_scrollable.is_some() { } else if cursor_over_scrollable.is_some() {
Status::Hovered { Status::Hovered {
is_horizontal_scrollbar_hovered: mouse_over_x_scrollbar, is_horizontal_scrollbar_hovered: mouse_over_x_scrollbar,
is_vertical_scrollbar_hovered: mouse_over_y_scrollbar, is_vertical_scrollbar_hovered: mouse_over_y_scrollbar,
is_horizontal_scrollbar_disabled: scrollbars.is_x_disabled(),
is_vertical_scrollbar_disabled: scrollbars.is_y_disabled(),
} }
} else { } else {
Status::Active Status::Active {
is_horizontal_scrollbar_disabled: scrollbars.is_x_disabled(),
is_vertical_scrollbar_disabled: scrollbars.is_y_disabled(),
}
}; };
if let Event::Window(window::Event::RedrawRequested(_now)) = event { if let Event::Window(window::Event::RedrawRequested(_now)) = event {
@ -968,8 +975,13 @@ where
_ => mouse::Cursor::Unavailable, _ => mouse::Cursor::Unavailable,
}; };
let style = theme let style = theme.style(
.style(&self.class, self.last_status.unwrap_or(Status::Active)); &self.class,
self.last_status.unwrap_or(Status::Active {
is_horizontal_scrollbar_disabled: false,
is_vertical_scrollbar_disabled: false,
}),
);
container::draw_background(renderer, &style.container, layout.bounds()); container::draw_background(renderer, &style.container, layout.bounds());
@ -1661,6 +1673,7 @@ impl Scrollbars {
bounds: scrollbar_bounds, bounds: scrollbar_bounds,
scroller, scroller,
alignment: vertical.alignment, alignment: vertical.alignment,
disabled: content_bounds.height <= bounds.height,
}) })
} else { } else {
None None
@ -1730,6 +1743,7 @@ impl Scrollbars {
bounds: scrollbar_bounds, bounds: scrollbar_bounds,
scroller, scroller,
alignment: horizontal.alignment, alignment: horizontal.alignment,
disabled: content_bounds.width <= bounds.width,
}) })
} else { } else {
None None
@ -1758,6 +1772,14 @@ impl Scrollbars {
} }
} }
fn is_y_disabled(&self) -> bool {
self.y.map(|y| y.disabled).unwrap_or(false)
}
fn is_x_disabled(&self) -> bool {
self.x.map(|x| x.disabled).unwrap_or(false)
}
fn grab_y_scroller(&self, cursor_position: Point) -> Option<f32> { fn grab_y_scroller(&self, cursor_position: Point) -> Option<f32> {
let scrollbar = self.y?; let scrollbar = self.y?;
let scroller = scrollbar.scroller?; let scroller = scrollbar.scroller?;
@ -1804,6 +1826,7 @@ pub(super) mod internals {
pub bounds: Rectangle, pub bounds: Rectangle,
pub scroller: Option<Scroller>, pub scroller: Option<Scroller>,
pub alignment: Anchor, pub alignment: Anchor,
pub disabled: bool,
} }
impl Scrollbar { impl Scrollbar {
@ -1867,13 +1890,22 @@ pub(super) mod internals {
#[derive(Debug, Clone, Copy, PartialEq, Eq)] #[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum Status { pub enum Status {
/// The [`Scrollable`] can be interacted with. /// The [`Scrollable`] can be interacted with.
Active, Active {
/// Whether or not the horizontal scrollbar is disabled meaning the content isn't overflowing.
is_horizontal_scrollbar_disabled: bool,
/// Whether or not the vertical scrollbar is disabled meaning the content isn't overflowing.
is_vertical_scrollbar_disabled: bool,
},
/// The [`Scrollable`] is being hovered. /// The [`Scrollable`] is being hovered.
Hovered { Hovered {
/// Indicates if the horizontal scrollbar is being hovered. /// Indicates if the horizontal scrollbar is being hovered.
is_horizontal_scrollbar_hovered: bool, is_horizontal_scrollbar_hovered: bool,
/// Indicates if the vertical scrollbar is being hovered. /// Indicates if the vertical scrollbar is being hovered.
is_vertical_scrollbar_hovered: bool, is_vertical_scrollbar_hovered: bool,
/// Whether or not the horizontal scrollbar is disabled meaning the content isn't overflowing.
is_horizontal_scrollbar_disabled: bool,
/// Whether or not the vertical scrollbar is disabled meaning the content isn't overflowing.
is_vertical_scrollbar_disabled: bool,
}, },
/// The [`Scrollable`] is being dragged. /// The [`Scrollable`] is being dragged.
Dragged { Dragged {
@ -1881,6 +1913,10 @@ pub enum Status {
is_horizontal_scrollbar_dragged: bool, is_horizontal_scrollbar_dragged: bool,
/// Indicates if the vertical scrollbar is being dragged. /// Indicates if the vertical scrollbar is being dragged.
is_vertical_scrollbar_dragged: bool, is_vertical_scrollbar_dragged: bool,
/// Whether or not the horizontal scrollbar is disabled meaning the content isn't overflowing.
is_horizontal_scrollbar_disabled: bool,
/// Whether or not the vertical scrollbar is disabled meaning the content isn't overflowing.
is_vertical_scrollbar_disabled: bool,
}, },
} }
@ -1958,7 +1994,7 @@ pub fn default(theme: &Theme, status: Status) -> Style {
}; };
match status { match status {
Status::Active => Style { Status::Active { .. } => Style {
container: container::Style::default(), container: container::Style::default(),
vertical_rail: scrollbar, vertical_rail: scrollbar,
horizontal_rail: scrollbar, horizontal_rail: scrollbar,
@ -1967,6 +2003,7 @@ pub fn default(theme: &Theme, status: Status) -> Style {
Status::Hovered { Status::Hovered {
is_horizontal_scrollbar_hovered, is_horizontal_scrollbar_hovered,
is_vertical_scrollbar_hovered, is_vertical_scrollbar_hovered,
..
} => { } => {
let hovered_scrollbar = Rail { let hovered_scrollbar = Rail {
scroller: Scroller { scroller: Scroller {
@ -1994,6 +2031,7 @@ pub fn default(theme: &Theme, status: Status) -> Style {
Status::Dragged { Status::Dragged {
is_horizontal_scrollbar_dragged, is_horizontal_scrollbar_dragged,
is_vertical_scrollbar_dragged, is_vertical_scrollbar_dragged,
..
} => { } => {
let dragged_scrollbar = Rail { let dragged_scrollbar = Rail {
scroller: Scroller { scroller: Scroller {