Fix further clippy lints

... and explicitly annotate crates as well.
This commit is contained in:
Héctor Ramón Jiménez 2022-07-09 18:03:59 +02:00
parent 33a24b5821
commit 2f76a10a1d
No known key found for this signature in database
GPG key ID: 140CC052C94F138E
33 changed files with 197 additions and 85 deletions

View file

@ -1,5 +1,5 @@
#![allow(missing_docs)]
#[derive(Debug)]
#[derive(Debug, Default)]
pub struct Debug;
impl Debug {

View file

@ -31,11 +31,19 @@
#![doc(
html_logo_url = "https://raw.githubusercontent.com/iced-rs/iced/9ab6923e943f784985e9ef9ca28b10278297225d/docs/logo.svg"
)]
#![deny(missing_docs)]
#![deny(missing_debug_implementations)]
#![deny(unused_results)]
#![forbid(unsafe_code)]
#![forbid(rust_2018_idioms)]
#![deny(
missing_debug_implementations,
missing_docs,
unused_results,
clippy::extra_unused_lifetimes,
clippy::from_over_into,
clippy::needless_borrow,
clippy::new_without_default,
clippy::useless_conversion
)]
#![forbid(unsafe_code, rust_2018_idioms)]
#![allow(clippy::inherent_to_string, clippy::type_complexity)]
#![cfg_attr(docsrs, feature(doc_cfg))]
pub mod clipboard;
pub mod command;
pub mod event;

View file

@ -489,15 +489,15 @@ where
}
}
impl<'a, T, Message, Renderer> Into<Element<'a, Message, Renderer>>
for List<'a, T, Renderer>
impl<'a, T, Message, Renderer> From<List<'a, T, Renderer>>
for Element<'a, Message, Renderer>
where
T: ToString + Clone,
Message: 'a,
Renderer: 'a + text::Renderer,
Renderer::Theme: StyleSheet,
{
fn into(self) -> Element<'a, Message, Renderer> {
Element::new(self)
fn from(list: List<'a, T, Renderer>) -> Self {
Element::new(list)
}
}

View file

@ -5,7 +5,7 @@ use crate::{Background, Font, Point, Rectangle, Size, Theme, Vector};
/// A renderer that does nothing.
///
/// It can be useful if you are writing tests!
#[derive(Debug, Clone, Copy)]
#[derive(Debug, Clone, Copy, Default)]
pub struct Null;
impl Null {

View file

@ -382,7 +382,7 @@ where
self.on_press.is_some(),
theme,
self.style,
|| &self.state,
|| self.state,
);
self.content.draw(

View file

@ -102,6 +102,12 @@ impl<'a, Message, Renderer> Column<'a, Message, Renderer> {
}
}
impl<'a, Message, Renderer> Default for Column<'a, Message, Renderer> {
fn default() -> Self {
Self::new()
}
}
impl<'a, Message, Renderer> Widget<Message, Renderer>
for Column<'a, Message, Renderer>
where

View file

@ -525,7 +525,7 @@ where
) -> Option<overlay::Element<'_, Message, Renderer>> {
overlay(
layout,
&mut self.state,
self.state,
self.padding,
self.text_size,
self.font.clone(),
@ -535,8 +535,8 @@ where
}
}
impl<'a, T: 'a, Message, Renderer> Into<Element<'a, Message, Renderer>>
for PickList<'a, T, Message, Renderer>
impl<'a, T: 'a, Message, Renderer> From<PickList<'a, T, Message, Renderer>>
for Element<'a, Message, Renderer>
where
T: Clone + ToString + Eq,
[T]: ToOwned<Owned = Vec<T>>,
@ -549,7 +549,7 @@ where
<Renderer::Theme as StyleSheet>::Style:
Into<<Renderer::Theme as menu::StyleSheet>::Style>,
{
fn into(self) -> Element<'a, Message, Renderer> {
Element::new(self)
fn from(pick_list: PickList<'a, T, Message, Renderer>) -> Self {
Element::new(pick_list)
}
}

View file

@ -76,7 +76,7 @@ where
}
}
impl<'a, Message, Renderer> Widget<Message, Renderer> for ProgressBar<Renderer>
impl<Message, Renderer> Widget<Message, Renderer> for ProgressBar<Renderer>
where
Renderer: crate::Renderer,
Renderer::Theme: StyleSheet,

View file

@ -102,6 +102,12 @@ impl<'a, Message, Renderer> Row<'a, Message, Renderer> {
}
}
impl<'a, Message, Renderer> Default for Row<'a, Message, Renderer> {
fn default() -> Self {
Self::new()
}
}
impl<'a, Message, Renderer> Widget<Message, Renderer>
for Row<'a, Message, Renderer>
where

View file

@ -662,7 +662,7 @@ where
shell: &mut Shell<'_, Message>,
) -> event::Status {
update(
&mut self.state,
self.state,
event,
layout,
cursor_position,
@ -693,7 +693,7 @@ where
renderer: &Renderer,
) -> mouse::Interaction {
mouse_interaction(
&self.state,
self.state,
layout,
cursor_position,
self.scrollbar_width,
@ -720,7 +720,7 @@ where
_viewport: &Rectangle,
) {
draw(
&self.state,
self.state,
renderer,
theme,
layout,

View file

@ -410,7 +410,7 @@ where
layout,
cursor_position,
shell,
&mut self.state,
self.state,
&mut self.value,
&self.range,
self.step,
@ -432,7 +432,7 @@ where
renderer,
layout,
cursor_position,
&self.state,
self.state,
self.value,
&self.range,
theme,

View file

@ -176,7 +176,7 @@ where
theme,
layout,
cursor_position,
&self.state,
self.state,
value.unwrap_or(&self.value),
&self.placeholder,
self.size,