Fix further clippy lints

... and explicitly annotate crates as well.

core/src/keyboard/modifiers.rs

@@ -5,7 +5,7 @@ bitflags! {
     #[derive(Default)]
     pub struct Modifiers: u32{
         /// The "shift" key.
-        const SHIFT = 0b100 << 0;
+        const SHIFT = 0b100;
         // const LSHIFT = 0b010 << 0;
         // const RSHIFT = 0b001 << 0;
         //

core/src/lib.rs

@@ -12,11 +12,18 @@
 #![doc(
     html_logo_url = "https://raw.githubusercontent.com/iced-rs/iced/9ab6923e943f784985e9ef9ca28b10278297225d/docs/logo.svg"
 )]
-#![deny(missing_docs)]
+#![deny(
-#![deny(missing_debug_implementations)]
+    missing_debug_implementations,
-#![deny(unused_results)]
+    missing_docs,
-#![forbid(unsafe_code)]
+    unused_results,
-#![forbid(rust_2018_idioms)]
+    clippy::extra_unused_lifetimes,
+    clippy::from_over_into,
+    clippy::needless_borrow,
+    clippy::new_without_default,
+    clippy::useless_conversion
+)]
+#![forbid(unsafe_code, rust_2018_idioms)]
+#![allow(clippy::inherent_to_string, clippy::type_complexity)]
 pub mod alignment;
 pub mod keyboard;
 pub mod mouse;

futures/src/lib.rs

@@ -4,13 +4,19 @@
 #![doc(
     html_logo_url = "https://raw.githubusercontent.com/iced-rs/iced/9ab6923e943f784985e9ef9ca28b10278297225d/docs/logo.svg"
 )]
-#![deny(missing_docs)]
+#![deny(
-#![deny(missing_debug_implementations)]
+    missing_debug_implementations,
-#![deny(unused_results)]
+    missing_docs,
-#![forbid(unsafe_code)]
+    unused_results,
-#![forbid(rust_2018_idioms)]
+    clippy::extra_unused_lifetimes,
+    clippy::from_over_into,
+    clippy::needless_borrow,
+    clippy::new_without_default,
+    clippy::useless_conversion
+)]
+#![forbid(unsafe_code, rust_2018_idioms)]
+#![allow(clippy::inherent_to_string, clippy::type_complexity)]
 #![cfg_attr(docsrs, feature(doc_cfg))]
-
 pub use futures;
 
 mod command;

futures/src/runtime.rs

@@ -66,8 +66,6 @@ where
 
         let future = future.then(|message| async move {
             let _ = sender.send(message).await;
-
-            ()
         });
 
         self.executor.spawn(future);

futures/src/subscription/tracker.rs

@@ -156,3 +156,13 @@ where
             });
     }
 }
+
+impl<Hasher, Event> Default for Tracker<Hasher, Event>
+where
+    Hasher: std::hash::Hasher + Default,
+    Event: 'static + Send + Clone,
+{
+    fn default() -> Self {
+        Self::new()
+    }
+}

glow/src/lib.rs

@@ -7,10 +7,18 @@
 #![doc(
     html_logo_url = "https://raw.githubusercontent.com/iced-rs/iced/9ab6923e943f784985e9ef9ca28b10278297225d/docs/logo.svg"
 )]
-#![deny(missing_docs)]
+#![deny(
-#![deny(missing_debug_implementations)]
+    missing_debug_implementations,
-#![deny(unused_results)]
+    missing_docs,
+    unused_results,
+    clippy::extra_unused_lifetimes,
+    clippy::from_over_into,
+    clippy::needless_borrow,
+    clippy::new_without_default,
+    clippy::useless_conversion
+)]
 #![forbid(rust_2018_idioms)]
+#![allow(clippy::inherent_to_string, clippy::type_complexity)]
 #![cfg_attr(docsrs, feature(doc_cfg))]
 
 pub use glow;

glutin/src/lib.rs

@@ -7,11 +7,20 @@
 #![doc(
     html_logo_url = "https://raw.githubusercontent.com/iced-rs/iced/9ab6923e943f784985e9ef9ca28b10278297225d/docs/logo.svg"
 )]
-#![deny(missing_docs)]
+#![deny(
-#![deny(missing_debug_implementations)]
+    missing_docs,
-#![deny(unused_results)]
+    missing_debug_implementations,
-#![deny(unsafe_code)]
+    unsafe_code,
+    unused_results,
+    clippy::extra_unused_lifetimes,
+    clippy::from_over_into,
+    clippy::needless_borrow,
+    clippy::new_without_default,
+    clippy::useless_conversion
+)]
 #![forbid(rust_2018_idioms)]
+#![allow(clippy::inherent_to_string, clippy::type_complexity)]
+#![cfg_attr(docsrs, feature(doc_cfg))]
 
 pub use glutin;
 

graphics/src/lib.rs

@@ -7,11 +7,19 @@
 #![doc(
     html_logo_url = "https://raw.githubusercontent.com/iced-rs/iced/9ab6923e943f784985e9ef9ca28b10278297225d/docs/logo.svg"
 )]
-#![deny(missing_docs)]
+#![deny(
-#![deny(missing_debug_implementations)]
+    missing_debug_implementations,
-#![deny(unused_results)]
+    missing_docs,
-#![deny(unsafe_code)]
+    unsafe_code,
+    unused_results,
+    clippy::extra_unused_lifetimes,
+    clippy::from_over_into,
+    clippy::needless_borrow,
+    clippy::new_without_default,
+    clippy::useless_conversion
+)]
 #![forbid(rust_2018_idioms)]
+#![allow(clippy::inherent_to_string, clippy::type_complexity)]
 #![cfg_attr(docsrs, feature(doc_cfg))]
 mod antialiasing;
 mod error;

lazy/src/component.rs

@@ -38,7 +38,7 @@ pub trait Component<Message, Renderer> {
 
     /// Produces the widgets of the [`Component`], which may trigger an [`Event`](Component::Event)
     /// on user interaction.
-    fn view(&mut self) -> Element<Self::Event, Renderer>;
+    fn view(&mut self) -> Element<'_, Self::Event, Renderer>;
 }
 
 /// Turns an implementor of [`Component`] into an [`Element`] that can be
@@ -350,7 +350,7 @@ where
         layout: Layout<'_>,
         cursor_position: Point,
     ) {
-        self.with_overlay_maybe(|overlay| {
+        let _ = self.with_overlay_maybe(|overlay| {
             overlay.draw(renderer, theme, style, layout, cursor_position);
         });
     }

lazy/src/lib.rs

@@ -1,6 +1,17 @@
 #![doc(
     html_logo_url = "https://raw.githubusercontent.com/iced-rs/iced/9ab6923e943f784985e9ef9ca28b10278297225d/docs/logo.svg"
 )]
+#![deny(
+    missing_debug_implementations,
+    unused_results,
+    clippy::extra_unused_lifetimes,
+    clippy::from_over_into,
+    clippy::needless_borrow,
+    clippy::new_without_default,
+    clippy::useless_conversion
+)]
+#![forbid(unsafe_code)]
+#![allow(clippy::inherent_to_string, clippy::type_complexity)]
 #![cfg_attr(docsrs, feature(doc_cfg))]
 pub mod component;
 pub mod responsive;

lazy/src/pure/component.rs

@@ -43,7 +43,7 @@ pub trait Component<Message, Renderer> {
 
     /// Produces the widgets of the [`Component`], which may trigger an [`Event`](Component::Event)
     /// on user interaction.
-    fn view(&self, state: &Self::State) -> Element<Self::Event, Renderer>;
+    fn view(&self, state: &Self::State) -> Element<'_, Self::Event, Renderer>;
 }
 
 /// Turns an implementor of [`Component`] into an [`Element`] that can be
@@ -382,7 +382,7 @@ where
         layout: Layout<'_>,
         cursor_position: Point,
     ) {
-        self.with_overlay_maybe(|overlay| {
+        let _ = self.with_overlay_maybe(|overlay| {
             overlay.draw(renderer, theme, style, layout, cursor_position);
         });
     }

lazy/src/pure/responsive.rs

@@ -341,7 +341,7 @@ where
         layout: Layout<'_>,
         cursor_position: Point,
     ) {
-        self.with_overlay_maybe(|overlay| {
+        let _ = self.with_overlay_maybe(|overlay| {
             overlay.draw(renderer, theme, style, layout, cursor_position);
         });
     }

lazy/src/responsive.rs

@@ -363,7 +363,7 @@ where
         layout: Layout<'_>,
         cursor_position: Point,
     ) {
-        self.with_overlay_maybe(|overlay| {
+        let _ = self.with_overlay_maybe(|overlay| {
             overlay.draw(renderer, theme, style, layout, cursor_position);
         });
     }

native/src/debug/null.rs

@@ -1,5 +1,5 @@
 #![allow(missing_docs)]
-#[derive(Debug)]
+#[derive(Debug, Default)]
 pub struct Debug;
 
 impl Debug {

native/src/lib.rs

@@ -31,11 +31,19 @@
 #![doc(
     html_logo_url = "https://raw.githubusercontent.com/iced-rs/iced/9ab6923e943f784985e9ef9ca28b10278297225d/docs/logo.svg"
 )]
-#![deny(missing_docs)]
+#![deny(
-#![deny(missing_debug_implementations)]
+    missing_debug_implementations,
-#![deny(unused_results)]
+    missing_docs,
-#![forbid(unsafe_code)]
+    unused_results,
-#![forbid(rust_2018_idioms)]
+    clippy::extra_unused_lifetimes,
+    clippy::from_over_into,
+    clippy::needless_borrow,
+    clippy::new_without_default,
+    clippy::useless_conversion
+)]
+#![forbid(unsafe_code, rust_2018_idioms)]
+#![allow(clippy::inherent_to_string, clippy::type_complexity)]
+#![cfg_attr(docsrs, feature(doc_cfg))]
 pub mod clipboard;
 pub mod command;
 pub mod event;

native/src/overlay/menu.rs

@@ -489,15 +489,15 @@ where
     }
 }
 
-impl<'a, T, Message, Renderer> Into<Element<'a, Message, Renderer>>
+impl<'a, T, Message, Renderer> From<List<'a, T, Renderer>>
-    for List<'a, T, Renderer>
+    for Element<'a, Message, Renderer>
 where
     T: ToString + Clone,
     Message: 'a,
     Renderer: 'a + text::Renderer,
     Renderer::Theme: StyleSheet,
 {
-    fn into(self) -> Element<'a, Message, Renderer> {
+    fn from(list: List<'a, T, Renderer>) -> Self {
-        Element::new(self)
+        Element::new(list)
     }
 }

native/src/renderer/null.rs

@@ -5,7 +5,7 @@ use crate::{Background, Font, Point, Rectangle, Size, Theme, Vector};
 /// A renderer that does nothing.
 ///
 /// It can be useful if you are writing tests!
-#[derive(Debug, Clone, Copy)]
+#[derive(Debug, Clone, Copy, Default)]
 pub struct Null;
 
 impl Null {

native/src/widget/button.rs

@@ -382,7 +382,7 @@ where
             self.on_press.is_some(),
             theme,
             self.style,
-            || &self.state,
+            || self.state,
         );
 
         self.content.draw(

native/src/widget/column.rs

@@ -102,6 +102,12 @@ impl<'a, Message, Renderer> Column<'a, Message, Renderer> {
     }
 }
 
+impl<'a, Message, Renderer> Default for Column<'a, Message, Renderer> {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl<'a, Message, Renderer> Widget<Message, Renderer>
     for Column<'a, Message, Renderer>
 where

native/src/widget/pick_list.rs

@@ -525,7 +525,7 @@ where
     ) -> Option<overlay::Element<'_, Message, Renderer>> {
         overlay(
             layout,
-            &mut self.state,
+            self.state,
             self.padding,
             self.text_size,
             self.font.clone(),
@@ -535,8 +535,8 @@ where
     }
 }
 
-impl<'a, T: 'a, Message, Renderer> Into<Element<'a, Message, Renderer>>
+impl<'a, T: 'a, Message, Renderer> From<PickList<'a, T, Message, Renderer>>
-    for PickList<'a, T, Message, Renderer>
+    for Element<'a, Message, Renderer>
 where
     T: Clone + ToString + Eq,
     [T]: ToOwned<Owned = Vec<T>>,
@@ -549,7 +549,7 @@ where
     <Renderer::Theme as StyleSheet>::Style:
         Into<<Renderer::Theme as menu::StyleSheet>::Style>,
 {
-    fn into(self) -> Element<'a, Message, Renderer> {
+    fn from(pick_list: PickList<'a, T, Message, Renderer>) -> Self {
-        Element::new(self)
+        Element::new(pick_list)
     }
 }

native/src/widget/progress_bar.rs

@@ -76,7 +76,7 @@ where
     }
 }
 
-impl<'a, Message, Renderer> Widget<Message, Renderer> for ProgressBar<Renderer>
+impl<Message, Renderer> Widget<Message, Renderer> for ProgressBar<Renderer>
 where
     Renderer: crate::Renderer,
     Renderer::Theme: StyleSheet,

native/src/widget/row.rs

@@ -102,6 +102,12 @@ impl<'a, Message, Renderer> Row<'a, Message, Renderer> {
     }
 }
 
+impl<'a, Message, Renderer> Default for Row<'a, Message, Renderer> {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl<'a, Message, Renderer> Widget<Message, Renderer>
     for Row<'a, Message, Renderer>
 where

native/src/widget/scrollable.rs

@@ -662,7 +662,7 @@ where
         shell: &mut Shell<'_, Message>,
     ) -> event::Status {
         update(
-            &mut self.state,
+            self.state,
             event,
             layout,
             cursor_position,
@@ -693,7 +693,7 @@ where
         renderer: &Renderer,
     ) -> mouse::Interaction {
         mouse_interaction(
-            &self.state,
+            self.state,
             layout,
             cursor_position,
             self.scrollbar_width,
@@ -720,7 +720,7 @@ where
         _viewport: &Rectangle,
     ) {
         draw(
-            &self.state,
+            self.state,
             renderer,
             theme,
             layout,

native/src/widget/slider.rs

@@ -410,7 +410,7 @@ where
             layout,
             cursor_position,
             shell,
-            &mut self.state,
+            self.state,
             &mut self.value,
             &self.range,
             self.step,
@@ -432,7 +432,7 @@ where
             renderer,
             layout,
             cursor_position,
-            &self.state,
+            self.state,
             self.value,
             &self.range,
             theme,

native/src/widget/text_input.rs

@@ -176,7 +176,7 @@ where
             theme,
             layout,
             cursor_position,
-            &self.state,
+            self.state,
             value.unwrap_or(&self.value),
             &self.placeholder,
             self.size,

pure/src/lib.rs

@@ -82,10 +82,18 @@
 #![doc(
     html_logo_url = "https://raw.githubusercontent.com/iced-rs/iced/9ab6923e943f784985e9ef9ca28b10278297225d/docs/logo.svg"
 )]
-#![deny(missing_docs)]
+#![deny(
-#![deny(unused_results)]
+    missing_docs,
-#![forbid(unsafe_code)]
+    unused_results,
-#![forbid(rust_2018_idioms)]
+    clippy::extra_unused_lifetimes,
+    clippy::from_over_into,
+    clippy::needless_borrow,
+    clippy::new_without_default,
+    clippy::useless_conversion
+)]
+#![forbid(rust_2018_idioms, unsafe_code)]
+#![allow(clippy::inherent_to_string, clippy::type_complexity)]
+#![cfg_attr(docsrs, feature(doc_cfg))]
 
 pub mod flex;
 pub mod helpers;

src/lib.rs

@@ -174,12 +174,20 @@
 #![doc(
     html_logo_url = "https://raw.githubusercontent.com/iced-rs/iced/9ab6923e943f784985e9ef9ca28b10278297225d/docs/logo.svg"
 )]
-#![deny(missing_docs)]
+#![deny(
-#![deny(missing_debug_implementations)]
+    missing_debug_implementations,
-#![deny(unused_results)]
+    missing_docs,
-#![forbid(unsafe_code)]
+    unused_results,
-#![forbid(rust_2018_idioms)]
+    clippy::extra_unused_lifetimes,
+    clippy::from_over_into,
+    clippy::needless_borrow,
+    clippy::new_without_default,
+    clippy::useless_conversion
+)]
+#![forbid(rust_2018_idioms, unsafe_code)]
+#![allow(clippy::inherent_to_string, clippy::type_complexity)]
 #![cfg_attr(docsrs, feature(doc_cfg))]
+
 mod element;
 mod error;
 mod result;

style/src/lib.rs

@@ -7,6 +7,16 @@
 #![doc(
     html_logo_url = "https://raw.githubusercontent.com/iced-rs/iced/9ab6923e943f784985e9ef9ca28b10278297225d/docs/logo.svg"
 )]
+#![deny(
+    unused_results,
+    clippy::extra_unused_lifetimes,
+    clippy::from_over_into,
+    clippy::needless_borrow,
+    clippy::new_without_default,
+    clippy::useless_conversion
+)]
+#![forbid(unsafe_code, rust_2018_idioms)]
+#![allow(clippy::inherent_to_string, clippy::type_complexity)]
 pub use iced_core::{Background, Color};
 
 pub mod application;

style/src/text.rs

@@ -6,13 +6,7 @@ pub trait StyleSheet {
     fn appearance(&self, style: Self::Style) -> Appearance;
 }
 
-#[derive(Debug, Clone, Copy)]
+#[derive(Debug, Clone, Copy, Default)]
 pub struct Appearance {
     pub color: Option<Color>,
 }
-
-impl Default for Appearance {
-    fn default() -> Self {
-        Self { color: None }
-    }
-}

style/src/theme.rs

@@ -419,7 +419,7 @@ impl radio::StyleSheet for Theme {
 
         radio::Appearance {
             background: Color::TRANSPARENT.into(),
-            dot_color: palette.primary.strong.color.into(),
+            dot_color: palette.primary.strong.color,
             border_width: 1.0,
             border_color: palette.primary.strong.color,
             text_color: None,
@@ -431,7 +431,7 @@ impl radio::StyleSheet for Theme {
         let palette = self.extended_palette();
 
         radio::Appearance {
-            dot_color: palette.primary.strong.color.into(),
+            dot_color: palette.primary.strong.color,
             background: palette.primary.weak.color.into(),
             ..active
         }
@@ -599,7 +599,7 @@ impl scrollable::StyleSheet for Theme {
             border_width: 0.0,
             border_color: Color::TRANSPARENT,
             scroller: scrollable::Scroller {
-                color: palette.background.strong.color.into(),
+                color: palette.background.strong.color,
                 border_radius: 2.0,
                 border_width: 0.0,
                 border_color: Color::TRANSPARENT,
@@ -616,7 +616,7 @@ impl scrollable::StyleSheet for Theme {
             border_width: 0.0,
             border_color: Color::TRANSPARENT,
             scroller: scrollable::Scroller {
-                color: palette.primary.strong.color.into(),
+                color: palette.primary.strong.color,
                 border_radius: 2.0,
                 border_width: 0.0,
                 border_color: Color::TRANSPARENT,

wgpu/src/backend.rs

@@ -230,7 +230,6 @@ impl Backend {
                                 wgpu_glyph::VerticalAlign::Bottom
                             }
                         }),
-                    ..Default::default()
                 };
 
                 self.text_pipeline.queue(text);

wgpu/src/lib.rs

@@ -23,11 +23,19 @@
 #![doc(
     html_logo_url = "https://raw.githubusercontent.com/iced-rs/iced/9ab6923e943f784985e9ef9ca28b10278297225d/docs/logo.svg"
 )]
-#![deny(missing_docs)]
+#![deny(
-#![deny(missing_debug_implementations)]
+    missing_debug_implementations,
-#![deny(unused_results)]
+    missing_docs,
-#![deny(unsafe_code)]
+    unsafe_code,
+    unused_results,
+    clippy::extra_unused_lifetimes,
+    clippy::from_over_into,
+    clippy::needless_borrow,
+    clippy::new_without_default,
+    clippy::useless_conversion
+)]
 #![forbid(rust_2018_idioms)]
+#![allow(clippy::inherent_to_string, clippy::type_complexity)]
 #![cfg_attr(docsrs, feature(doc_cfg))]
 
 pub mod settings;

winit/src/lib.rs

@@ -17,11 +17,19 @@
 #![doc(
     html_logo_url = "https://raw.githubusercontent.com/iced-rs/iced/9ab6923e943f784985e9ef9ca28b10278297225d/docs/logo.svg"
 )]
-#![deny(missing_docs)]
+#![deny(
-#![deny(missing_debug_implementations)]
+    missing_debug_implementations,
-#![deny(unused_results)]
+    missing_docs,
-#![forbid(unsafe_code)]
+    unused_results,
-#![forbid(rust_2018_idioms)]
+    clippy::extra_unused_lifetimes,
+    clippy::from_over_into,
+    clippy::needless_borrow,
+    clippy::new_without_default,
+    clippy::useless_conversion
+)]
+#![forbid(rust_2018_idioms, unsafe_code)]
+#![allow(clippy::inherent_to_string, clippy::type_complexity)]
+#![cfg_attr(docsrs, feature(doc_cfg))]
 
 #[doc(no_inline)]
 pub use iced_native::*;