Remove unnecessary Rc in both Element::map

This commit is contained in:
Héctor Ramón Jiménez 2020-07-16 04:40:36 +02:00
parent 73d1353976
commit 31c30fedd5
2 changed files with 6 additions and 8 deletions

View file

@ -2,7 +2,6 @@ use crate::{
layout, overlay, Clipboard, Color, Event, Hasher, Layout, Length, Point, layout, overlay, Clipboard, Color, Event, Hasher, Layout, Length, Point,
Widget, Widget,
}; };
use std::rc::Rc;
/// A generic [`Widget`]. /// A generic [`Widget`].
/// ///
@ -286,7 +285,7 @@ where
struct Map<'a, A, B, Renderer> { struct Map<'a, A, B, Renderer> {
widget: Box<dyn Widget<A, Renderer> + 'a>, widget: Box<dyn Widget<A, Renderer> + 'a>,
mapper: Rc<dyn Fn(A) -> B>, mapper: Box<dyn Fn(A) -> B>,
} }
impl<'a, A, B, Renderer> Map<'a, A, B, Renderer> { impl<'a, A, B, Renderer> Map<'a, A, B, Renderer> {
@ -299,7 +298,7 @@ impl<'a, A, B, Renderer> Map<'a, A, B, Renderer> {
{ {
Map { Map {
widget, widget,
mapper: Rc::new(mapper), mapper: Box::new(mapper),
} }
} }
} }
@ -370,7 +369,7 @@ where
&mut self, &mut self,
layout: Layout<'_>, layout: Layout<'_>,
) -> Option<overlay::Element<'_, B, Renderer>> { ) -> Option<overlay::Element<'_, B, Renderer>> {
let mapper = self.mapper.clone(); let mapper = &self.mapper;
self.widget self.widget
.overlay(layout) .overlay(layout)

View file

@ -1,7 +1,6 @@
pub use crate::Overlay; pub use crate::Overlay;
use crate::{layout, Clipboard, Event, Hasher, Layout, Point, Size, Vector}; use crate::{layout, Clipboard, Event, Hasher, Layout, Point, Size, Vector};
use std::rc::Rc;
/// A generic [`Overlay`]. /// A generic [`Overlay`].
/// ///
@ -38,7 +37,7 @@ where
/// Applies a transformation to the produced message of the [`Element`]. /// Applies a transformation to the produced message of the [`Element`].
/// ///
/// [`Element`]: struct.Element.html /// [`Element`]: struct.Element.html
pub fn map<B>(self, f: Rc<dyn Fn(Message) -> B>) -> Element<'a, B, Renderer> pub fn map<B>(self, f: &'a dyn Fn(Message) -> B) -> Element<'a, B, Renderer>
where where
Message: 'a, Message: 'a,
Renderer: 'a, Renderer: 'a,
@ -104,13 +103,13 @@ where
struct Map<'a, A, B, Renderer> { struct Map<'a, A, B, Renderer> {
content: Box<dyn Overlay<A, Renderer> + 'a>, content: Box<dyn Overlay<A, Renderer> + 'a>,
mapper: Rc<dyn Fn(A) -> B>, mapper: &'a dyn Fn(A) -> B,
} }
impl<'a, A, B, Renderer> Map<'a, A, B, Renderer> { impl<'a, A, B, Renderer> Map<'a, A, B, Renderer> {
pub fn new( pub fn new(
content: Box<dyn Overlay<A, Renderer> + 'a>, content: Box<dyn Overlay<A, Renderer> + 'a>,
mapper: Rc<dyn Fn(A) -> B + 'static>, mapper: &'a dyn Fn(A) -> B,
) -> Map<'a, A, B, Renderer> { ) -> Map<'a, A, B, Renderer> {
Map { content, mapper } Map { content, mapper }
} }