Chore: Inline format args for ease of reading

A minor cleanup to inline all simple cases of format arguments. Makes the format strings just a bit easier to read.
This commit is contained in:
Yuri Astrakhan 2023-09-19 01:31:10 -04:00
parent 4613eb26cb
commit 3d6b9637c3
13 changed files with 25 additions and 30 deletions

View file

@ -610,8 +610,7 @@ mod grid {
frame.fill_text(Text { frame.fill_text(Text {
content: format!( content: format!(
"{} cell{} @ {:?} ({})", "{cell_count} cell{} @ {:?} ({})",
cell_count,
if cell_count == 1 { "" } else { "s" }, if cell_count == 1 { "" } else { "s" },
self.last_tick_duration, self.last_tick_duration,
self.last_queued_ticks self.last_queued_ticks

View file

@ -184,8 +184,8 @@ impl Application for Example {
.align_items(Alignment::Center); .align_items(Alignment::Center);
if let Some(crop_error) = &self.crop_error { if let Some(crop_error) = &self.crop_error {
crop_controls = crop_controls crop_controls =
.push(text(format!("Crop error! \n{}", crop_error))); crop_controls.push(text(format!("Crop error! \n{crop_error}")));
} }
let mut controls = column![ let mut controls = column![
@ -221,9 +221,9 @@ impl Application for Example {
if let Some(png_result) = &self.saved_png_path { if let Some(png_result) = &self.saved_png_path {
let msg = match png_result { let msg = match png_result {
Ok(path) => format!("Png saved as: {:?}!", path), Ok(path) => format!("Png saved as: {path:?}!"),
Err(msg) => { Err(msg) => {
format!("Png could not be saved due to:\n{:?}", msg) format!("Png could not be saved due to:\n{msg:?}")
} }
}; };
@ -281,7 +281,7 @@ async fn save_to_png(screenshot: Screenshot) -> Result<String, PngError> {
ColorType::Rgba8, ColorType::Rgba8,
) )
.map(|_| path) .map(|_| path)
.map_err(|err| PngError(format!("{:?}", err))) .map_err(|err| PngError(format!("{err:?}")))
} }
#[derive(Clone, Debug)] #[derive(Clone, Debug)]

View file

@ -105,8 +105,8 @@ impl Application for Example {
ByteSize::kb(information.memory_total).to_string(); ByteSize::kb(information.memory_total).to_string();
let memory_total = text(format!( let memory_total = text(format!(
"Memory (total): {} kb ({})", "Memory (total): {} kb ({memory_readable})",
information.memory_total, memory_readable information.memory_total,
)); ));
let memory_text = if let Some(memory_used) = let memory_text = if let Some(memory_used) =

View file

@ -415,8 +415,7 @@ fn view_controls(tasks: &[Task], current_filter: Filter) -> Element<Message> {
row![ row![
text(format!( text(format!(
"{} {} left", "{tasks_left} {} left",
tasks_left,
if tasks_left == 1 { "task" } else { "tasks" } if tasks_left == 1 { "task" } else { "tasks" }
)) ))
.width(Length::Fill), .width(Length::Fill),

View file

@ -94,7 +94,7 @@ impl Application for Example {
data_row( data_row(
label, label,
match bounds { match bounds {
Some(bounds) => format!("{:?}", bounds), Some(bounds) => format!("{bounds:?}"),
None => "not visible".to_string(), None => "not visible".to_string(),
}, },
if bounds if bounds

View file

@ -147,8 +147,7 @@ impl Tracker {
.for_each(|listener| { .for_each(|listener| {
if let Err(error) = listener.try_send((event.clone(), status)) { if let Err(error) = listener.try_send((event.clone(), status)) {
log::warn!( log::warn!(
"Error sending event to subscription: {:?}", "Error sending event to subscription: {error:?}"
error
); );
} }
}); });

View file

@ -60,7 +60,7 @@ impl<T> Renderer<T> {
pub fn draw_mesh(&mut self, mesh: Mesh) { pub fn draw_mesh(&mut self, mesh: Mesh) {
match self { match self {
Self::TinySkia(_) => { Self::TinySkia(_) => {
log::warn!("Unsupported mesh primitive: {:?}", mesh) log::warn!("Unsupported mesh primitive: {mesh:?}")
} }
#[cfg(feature = "wgpu")] #[cfg(feature = "wgpu")]
Self::Wgpu(renderer) => { Self::Wgpu(renderer) => {

View file

@ -443,8 +443,7 @@ impl Backend {
#[cfg(not(feature = "image"))] #[cfg(not(feature = "image"))]
Primitive::Image { .. } => { Primitive::Image { .. } => {
log::warn!( log::warn!(
"Unsupported primitive in `iced_tiny_skia`: {:?}", "Unsupported primitive in `iced_tiny_skia`: {primitive:?}",
primitive
); );
} }
#[cfg(feature = "svg")] #[cfg(feature = "svg")]
@ -473,8 +472,7 @@ impl Backend {
#[cfg(not(feature = "svg"))] #[cfg(not(feature = "svg"))]
Primitive::Svg { .. } => { Primitive::Svg { .. } => {
log::warn!( log::warn!(
"Unsupported primitive in `iced_tiny_skia`: {:?}", "Unsupported primitive in `iced_tiny_skia`: {primitive:?}",
primitive
); );
} }
Primitive::Custom(primitive::Custom::Fill { Primitive::Custom(primitive::Custom::Fill {

View file

@ -86,7 +86,7 @@ impl Atlas {
entry entry
}; };
log::info!("Allocated atlas entry: {:?}", entry); log::info!("Allocated atlas entry: {entry:?}");
// It is a webgpu requirement that: // It is a webgpu requirement that:
// BufferCopyView.layout.bytes_per_row % wgpu::COPY_BYTES_PER_ROW_ALIGNMENT == 0 // BufferCopyView.layout.bytes_per_row % wgpu::COPY_BYTES_PER_ROW_ALIGNMENT == 0
@ -139,13 +139,13 @@ impl Atlas {
} }
} }
log::info!("Current atlas: {:?}", self); log::info!("Current atlas: {self:?}");
Some(entry) Some(entry)
} }
pub fn remove(&mut self, entry: &Entry) { pub fn remove(&mut self, entry: &Entry) {
log::info!("Removing atlas entry: {:?}", entry); log::info!("Removing atlas entry: {entry:?}");
match entry { match entry {
Entry::Contiguous(allocation) => { Entry::Contiguous(allocation) => {
@ -258,7 +258,7 @@ impl Atlas {
} }
fn deallocate(&mut self, allocation: &Allocation) { fn deallocate(&mut self, allocation: &Allocation) {
log::info!("Deallocating atlas: {:?}", allocation); log::info!("Deallocating atlas: {allocation:?}");
match allocation { match allocation {
Allocation::Full { layer } => { Allocation::Full { layer } => {

View file

@ -152,7 +152,7 @@ impl Cache {
let allocation = let allocation =
atlas.upload(device, encoder, width, height, &rgba)?; atlas.upload(device, encoder, width, height, &rgba)?;
log::debug!("allocating {} {}x{}", id, width, height); log::debug!("allocating {id} {width}x{height}");
let _ = self.svg_hits.insert(id); let _ = self.svg_hits.insert(id);
let _ = self.rasterized_hits.insert(key); let _ = self.rasterized_hits.insert(key);

View file

@ -35,7 +35,7 @@ impl<Theme> Compositor<Theme> {
..Default::default() ..Default::default()
}); });
log::info!("{:#?}", settings); log::info!("{settings:#?}");
#[cfg(not(target_arch = "wasm32"))] #[cfg(not(target_arch = "wasm32"))]
if log::max_level() >= log::LevelFilter::Info { if log::max_level() >= log::LevelFilter::Info {
@ -43,7 +43,7 @@ impl<Theme> Compositor<Theme> {
.enumerate_adapters(settings.internal_backend) .enumerate_adapters(settings.internal_backend)
.map(|adapter| adapter.get_info()) .map(|adapter| adapter.get_info())
.collect(); .collect();
log::info!("Available adapters: {:#?}", available_adapters); log::info!("Available adapters: {available_adapters:#?}");
} }
#[allow(unsafe_code)] #[allow(unsafe_code)]
@ -83,7 +83,7 @@ impl<Theme> Compositor<Theme> {
}) })
})?; })?;
log::info!("Selected format: {:?}", format); log::info!("Selected format: {format:?}");
#[cfg(target_arch = "wasm32")] #[cfg(target_arch = "wasm32")]
let limits = [wgpu::Limits::downlevel_webgl2_defaults() let limits = [wgpu::Limits::downlevel_webgl2_defaults()

View file

@ -157,7 +157,7 @@ where
) )
.with_visible(false); .with_visible(false);
log::debug!("Window builder: {:#?}", builder); log::debug!("Window builder: {builder:#?}");
let window = builder let window = builder
.build(&event_loop) .build(&event_loop)
@ -174,7 +174,7 @@ where
let body = document.body().unwrap(); let body = document.body().unwrap();
let target = target.and_then(|target| { let target = target.and_then(|target| {
body.query_selector(&format!("#{}", target)) body.query_selector(&format!("#{target}"))
.ok() .ok()
.unwrap_or(None) .unwrap_or(None)
}); });

View file

@ -45,7 +45,7 @@ impl Clipboard {
State::Connected(clipboard) => match clipboard.write(contents) { State::Connected(clipboard) => match clipboard.write(contents) {
Ok(()) => {} Ok(()) => {}
Err(error) => { Err(error) => {
log::warn!("error writing to clipboard: {}", error) log::warn!("error writing to clipboard: {error}")
} }
}, },
State::Unavailable => {} State::Unavailable => {}