me/iced
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #2599 from iced-rs/replace-rc-with-arc-for-markdown

Browse source 
Replace `Rc` with `Arc` for `markdown` caching
This commit is contained in:
Héctor Ramón 2024-09-21 22:39:03 +02:00 • committed by GitHub
commit 88a2fac1f9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
widget/src/markdown.rs
View file

@ -57,7 +57,7 @@ use crate::core::{
use crate::{column, container, rich_text, row, scrollable, span, text};
use std::cell::{Cell, RefCell};
use std::rc::Rc;
use std::sync::Arc;
pub use core::text::Highlight;
pub use pulldown_cmark::HeadingLevel;
@ -88,7 +88,7 @@ pub enum Item {
pub struct Text {
spans: Vec<Span>,
last_style: Cell<Option<Style>>,
last_styled_spans: RefCell<Rc<[text::Span<'static, Url>]>>,
last_styled_spans: RefCell<Arc<[text::Span<'static, Url>]>>,
}
impl Text {
@ -104,7 +104,7 @@ impl Text {
///
/// This method performs caching for you. It will only reallocate if the [`Style`]
/// provided changes.
pub fn spans(&self, style: Style) -> Rc<[text::Span<'static, Url>]> {
pub fn spans(&self, style: Style) -> Arc<[text::Span<'static, Url>]> {
if Some(style) != self.last_style.get() {
*self.last_styled_spans.borrow_mut() =
self.spans.iter().map(|span| span.view(&style)).collect();