Add FetchSize command - apply the changes discussed at #water-cooler

This commit is contained in:
Yiğit Özdemir 2023-06-22 18:28:32 +03:00
parent 21a71b753d
commit b394c84b37
No known key found for this signature in database
GPG key ID: 7FDC39C00954F1C7
4 changed files with 7 additions and 38 deletions

View file

@ -6,12 +6,10 @@ mod level;
mod mode;
mod redraw_request;
mod user_attention;
mod fetch_size;
pub use event::Event;
pub use icon::Icon;
pub use level::Level;
pub use mode::Mode;
pub use redraw_request::RedrawRequest;
pub use user_attention::UserAttention;
pub use fetch_size::SizeType;
pub use user_attention::UserAttention;

View file

@ -1,8 +0,0 @@
/// A `struct` defining which size to fetch.
#[derive(Debug, Clone, Copy)]
pub enum SizeType {
/// Inner size. (not including title bars and so other OS decorations)
Inner,
/// Outer size. (including everything)
Outer,
}

View file

@ -1,7 +1,3 @@
use iced_core::window::SizeType;
use crate::core::window::{Icon, Level, Mode, UserAttention};
use crate::futures::MaybeSend;
@ -25,12 +21,7 @@ pub enum Action<T> {
height: u32,
},
/// Fetch the current size of the window.
FetchSize {
/// Which size to fetch
size_type: SizeType,
/// Callback function
callback: Box<dyn FnOnce((u32, u32)) -> T + 'static>,
},
FetchSize(Box<dyn FnOnce((u32, u32)) -> T + 'static>),
/// Set the window to maximized or back
Maximize(bool),
/// Set the window to minimized or back
@ -115,10 +106,7 @@ impl<T> Action<T> {
Self::Close => Action::Close,
Self::Drag => Action::Drag,
Self::Resize { width, height } => Action::Resize { width, height },
Self::FetchSize { size_type, callback } => Action::FetchSize {
size_type: size_type,
callback: Box::new(move |s| f(callback(s))),
},
Self::FetchSize(o) => Action::FetchSize(Box::new(move |s| f(o(s)))),
Self::Maximize(maximized) => Action::Maximize(maximized),
Self::Minimize(minimized) => Action::Minimize(minimized),
Self::Move { x, y } => Action::Move { x, y },
@ -146,7 +134,7 @@ impl<T> fmt::Debug for Action<T> {
f,
"Action::Resize {{ widget: {width}, height: {height} }}"
),
Self::FetchSize { size_type, .. } => write!(f, "Action::FetchSize {{ size_type: {size_type:?} }}"),
Self::FetchSize(_) => write!(f, "Action::FetchSize"),
Self::Maximize(maximized) => {
write!(f, "Action::Maximize({maximized})")
}

View file

@ -3,7 +3,6 @@
mod profiler;
mod state;
use iced_graphics::core::window::SizeType;
pub use state::State;
use crate::conversion;
@ -748,19 +747,11 @@ pub fn run_command<A, E>(
height,
});
}
window::Action::FetchSize {
size_type,
callback,
} => {
let width_height = match size_type {
SizeType::Inner => window.inner_size(),
SizeType::Outer => window.outer_size(),
};
let width_height =
(width_height.width, width_height.height);
window::Action::FetchSize(callback) => {
let size = window.inner_size();
proxy
.send_event(callback(width_height))
.send_event(callback((size.width, size.height)))
.expect("Send message to event loop")
}
window::Action::Maximize(maximized) => {