me/iced
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #1633 from pop-os/standardize-checkbox-functions

Browse source 
use same name & order for checkbox::new and helper
This commit is contained in:
Héctor Ramón 2023-01-05 18:35:24 +01:00 • committed by GitHub
commit d29849df79
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
native/src/widget/checkbox.rs
View file

@ -27,7 +27,7 @@ pub use iced_style::checkbox::{Appearance, StyleSheet};
/// ///
/// let is_checked = true; /// let is_checked = true;
/// ///
/// Checkbox::new(is_checked, "Toggle me!", Message::CheckboxToggled); /// Checkbox::new("Toggle me!", is_checked, Message::CheckboxToggled);
/// ``` /// ```
/// ///
/// ![Checkbox drawn by `iced_wgpu`](https://github.com/iced-rs/iced/blob/7760618fb112074bc40b148944521f312152012a/docs/images/checkbox.png?raw=true) /// ![Checkbox drawn by `iced_wgpu`](https://github.com/iced-rs/iced/blob/7760618fb112074bc40b148944521f312152012a/docs/images/checkbox.png?raw=true)
@ -67,7 +67,7 @@ where
/// * a function that will be called when the [`Checkbox`] is toggled. It /// * a function that will be called when the [`Checkbox`] is toggled. It
/// will receive the new state of the [`Checkbox`] and must produce a /// will receive the new state of the [`Checkbox`] and must produce a
/// `Message`. /// `Message`.
pub fn new<F>(is_checked: bool, label: impl Into<String>, f: F) -> Self pub fn new<F>(label: impl Into<String>, is_checked: bool, f: F) -> Self
where where
F: 'a + Fn(bool) -> Message, F: 'a + Fn(bool) -> Message,
{ {

2
native/src/widget/helpers.rs
View file

@ -129,7 +129,7 @@ where
Renderer: crate::text::Renderer, Renderer: crate::text::Renderer,
Renderer::Theme: widget::checkbox::StyleSheet + widget::text::StyleSheet, Renderer::Theme: widget::checkbox::StyleSheet + widget::text::StyleSheet,
{ {
widget::Checkbox::new(is_checked, label, f) widget::Checkbox::new(label, is_checked, f)
} }
/// Creates a new [`Radio`]. /// Creates a new [`Radio`].