Merge pull request #1742 from bungoboingo/fix/fullscreen

[Fix] Fullscreen only works on primary monitor
This commit is contained in:
Héctor Ramón 2023-03-03 21:20:11 +01:00 committed by GitHub
commit d73ca4de0f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 21 additions and 3 deletions

View file

@ -1,6 +1,6 @@
use iced::alignment::{self, Alignment}; use iced::alignment::{self, Alignment};
use iced::event::{self, Event}; use iced::event::{self, Event};
use iced::keyboard; use iced::keyboard::{self, KeyCode, Modifiers};
use iced::subscription; use iced::subscription;
use iced::theme::{self, Theme}; use iced::theme::{self, Theme};
use iced::widget::{ use iced::widget::{
@ -50,6 +50,7 @@ enum Message {
FilterChanged(Filter), FilterChanged(Filter),
TaskMessage(usize, TaskMessage), TaskMessage(usize, TaskMessage),
TabPressed { shift: bool }, TabPressed { shift: bool },
ToggleFullscreen(window::Mode),
} }
impl Application for Todos { impl Application for Todos {
@ -156,6 +157,9 @@ impl Application for Todos {
widget::focus_next() widget::focus_next()
} }
} }
Message::ToggleFullscreen(mode) => {
window::change_mode(mode)
}
_ => Command::none(), _ => Command::none(),
}; };
@ -266,6 +270,21 @@ impl Application for Todos {
) => Some(Message::TabPressed { ) => Some(Message::TabPressed {
shift: modifiers.shift(), shift: modifiers.shift(),
}), }),
(
Event::Keyboard(keyboard::Event::KeyPressed {
key_code,
modifiers: Modifiers::SHIFT,
}),
event::Status::Ignored,
) => match key_code {
KeyCode::Up => {
Some(Message::ToggleFullscreen(window::Mode::Fullscreen))
}
KeyCode::Down => {
Some(Message::ToggleFullscreen(window::Mode::Windowed))
}
_ => None,
},
_ => None, _ => None,
}) })
} }

View file

@ -8,5 +8,4 @@ pub use icon::Icon;
pub use position::Position; pub use position::Position;
pub use settings::Settings; pub use settings::Settings;
#[cfg(not(target_arch = "wasm32"))]
pub use crate::runtime::window::*; pub use crate::runtime::window::*;

View file

@ -762,7 +762,7 @@ pub fn run_command<A, E>(
window::Action::ChangeMode(mode) => { window::Action::ChangeMode(mode) => {
window.set_visible(conversion::visible(mode)); window.set_visible(conversion::visible(mode));
window.set_fullscreen(conversion::fullscreen( window.set_fullscreen(conversion::fullscreen(
window.primary_monitor(), window.current_monitor(),
mode, mode,
)); ));
} }