Chore: Apply some minor clippy fixes

* Use `.elapsed()` for duration
* Use direct iteration without calling `.iter()` and the like
* order fields in the `Text` struct creation as declared
This commit is contained in:
Yuri Astrakhan 2023-09-19 01:52:25 -04:00
parent 4613eb26cb
commit efd0ff6ded
7 changed files with 13 additions and 19 deletions

View file

@ -94,7 +94,7 @@ impl Linear {
mut self,
stops: impl IntoIterator<Item = ColorStop>,
) -> Self {
for stop in stops.into_iter() {
for stop in stops {
self = self.add_stop(stop.offset, stop.color)
}

View file

@ -220,9 +220,9 @@ where
size,
line_height,
font,
shaping,
horizontal_alignment,
vertical_alignment,
shaping,
},
);

View file

@ -793,7 +793,7 @@ mod grid {
}
}
for (cell, amount) in adjacent_life.iter() {
for (cell, amount) in &adjacent_life {
match amount {
2 => {}
3 => {

View file

@ -482,7 +482,7 @@ impl<'a> Step {
column(
Language::all()
.iter()
.cloned()
.copied()
.map(|language| {
radio(
language,

View file

@ -87,7 +87,7 @@ impl Linear {
mut self,
stops: impl IntoIterator<Item = ColorStop>,
) -> Self {
for stop in stops.into_iter() {
for stop in stops {
self = self.add_stop(stop.offset, stop.color)
}

View file

@ -75,7 +75,7 @@ impl Debug {
}
pub fn startup_finished(&mut self) {
self.startup_duration = time::Instant::now() - self.startup_start;
self.startup_duration = self.startup_start.elapsed();
}
pub fn update_started(&mut self) {
@ -83,8 +83,7 @@ impl Debug {
}
pub fn update_finished(&mut self) {
self.update_durations
.push(time::Instant::now() - self.update_start);
self.update_durations.push(self.update_start.elapsed());
}
pub fn view_started(&mut self) {
@ -92,8 +91,7 @@ impl Debug {
}
pub fn view_finished(&mut self) {
self.view_durations
.push(time::Instant::now() - self.view_start);
self.view_durations.push(self.view_start.elapsed());
}
pub fn layout_started(&mut self) {
@ -101,8 +99,7 @@ impl Debug {
}
pub fn layout_finished(&mut self) {
self.layout_durations
.push(time::Instant::now() - self.layout_start);
self.layout_durations.push(self.layout_start.elapsed());
}
pub fn event_processing_started(&mut self) {
@ -110,8 +107,7 @@ impl Debug {
}
pub fn event_processing_finished(&mut self) {
self.event_durations
.push(time::Instant::now() - self.event_start);
self.event_durations.push(self.event_start.elapsed());
}
pub fn draw_started(&mut self) {
@ -119,8 +115,7 @@ impl Debug {
}
pub fn draw_finished(&mut self) {
self.draw_durations
.push(time::Instant::now() - self.draw_start);
self.draw_durations.push(self.draw_start.elapsed());
}
pub fn render_started(&mut self) {
@ -128,8 +123,7 @@ impl Debug {
}
pub fn render_finished(&mut self) {
self.render_durations
.push(time::Instant::now() - self.render_start);
self.render_durations.push(self.render_start.elapsed());
}
pub fn log_message<Message: std::fmt::Debug>(&mut self, message: &Message) {

View file

@ -182,7 +182,7 @@ fn convert_path(path: &Path) -> Option<tiny_skia::Path> {
let mut builder = tiny_skia::PathBuilder::new();
let mut last_point = Default::default();
for event in path.raw().iter() {
for event in path.raw() {
match event {
lyon_path::Event::Begin { at } => {
builder.move_to(at.x, at.y);