me/iced
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove PartialOrd implementation for Rectangle

Browse source 
A `PartialOrd` implementation is unclear for this type, since it has
a position besides its dimensions.
This commit is contained in:
Héctor Ramón Jiménez 2023-01-08 20:19:36 +01:00
parent 19f4373863
commit f64e95e246
No known key found for this signature in database
GPG key ID: 140CC052C94F138E
2 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
core/src/rectangle.rs
View file

@ -111,12 +111,6 @@ impl Rectangle<f32> {
}
}
impl std::cmp::PartialOrd for Rectangle<f32> {
fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
(self.width * self.height).partial_cmp(&(other.width * other.height))
}
}
impl std::ops::Mul<f32> for Rectangle<f32> {
type Output = Self;

4
native/src/widget/scrollable.rs
View file

@ -896,7 +896,9 @@ fn notify_on_scroll<Message>(
shell: &mut Shell<'_, Message>,
) {
if let Some(on_scroll) = on_scroll {
if content_bounds <= bounds {
if content_bounds.width <= bounds.width
&& content_bounds.height <= bounds.height
{
return;
}